Issue Details (XML | Word | Printable)

Key: LIBOMV-340
Type: Bug Bug
Status: Resolved Resolved
Resolution: Fixed
Priority: Minor Minor
Assignee: Dirty McLean
Reporter: omei turnbull
Votes: 0
Watchers: 0
Operations

If you were logged in you would be able to see more operations.
libopenmetaverse

ObjectManager not removing av from ObjectsAvatars.Dictionary when killed

Created: 31/Jul/08 07:24 PM   Updated: 25/Oct/08 09:19 AM
Component/s: Objects
Affects Version/s: 0.5.0
Fix Version/s: 0.6.0

File Attachments: 1. Text File libsecondlife_onobjectkilled.patch (3 kB)
2. File ObjectManager.diff (0.8 kB)

Issue Links:
Duplicate
 

Environment: All
Steps to Reproduce:
Using TestClient:

1) Start TestClient
2) Using a second account, log in to the region with the bot.
3) Run the who command. Second av should be in list.
4) Teleport 2nd av out of region.
5) Run the who command again. Second av will still be in the list.
6) Teleport the 2nd av back into the region.
7) Run the who command again. There will now be two instances of the 2nd av in the list.

I believe the attached patch is an appropriate fix.



 Description  « Hide
When an object representing an avatar is killed, it is removed from the ObjectsPrimitives dictionary, but not the ObjectsAvatars dictionary.

 All   Comments   Change History   Subversion Commits   Patches      Sort Order: Ascending order - Click to sort in descending order
Jim Radford added a comment - 04/Aug/08 10:22 PM
This was fixed in our release versin 0.5.0, please confirm you are using at least that version and reopen if you continue to have issues.

omei turnbull added a comment - 05/Aug/08 10:50 AM
I'm seeing this with code pulled from the SVN trunk on 7/29/08. Comparing that to the 0.5.0 tarball I don't see any relevant differences.

I've since discovered that while my suggested patch is a big improvement, duplicate av instances do still build up. So it will take more than just my patch to fix completely.


Alexis Tabary added a comment - 30/Sep/08 07:23 AM
Removes avatars from "simulator.ObjectsAvatars.Dictionary", with a lock for thread safety.

Dirty McLean added a comment - 25/Oct/08 09:19 AM
Fixed in r2308