[#LIBOMV-413] RequestGroupRoleMembers does not add to GroupRolesMembersRequests

libopenmetaverse

RequestGroupRoleMembers does not add to GroupRolesMembersRequests

Created: 05/Nov/08 02:09 AM Updated: 10/Nov/08 03:23 AM

Component/s:

Groups

Affects Version/s:

None

Fix Version/s:

0.6.0

File Attachments:

fix_group_cache_rolesmembers_inconsistancy.patch (0.9 kB)
2.

fix_group_cache_rolesmembers_inconsistancy2.patch (0.8 kB)

Environment:

All

Description

« Hide

Very small inconstancy with the clean ups in the GroupManager , to the group caches and RequestGroupRoleMembers(UUID group) did not appear to have the same clean up as the other group request functions. With out the attached patch the GroupRolesMembersCaches never gets populated as the request id is not added to the list.

All

Comments

Change History

Subversion Commits

Patches

Sort Order:

[ Permalink | « Hide ]

Robin Cornelius added a comment - 05/Nov/08 04:17 AM

Oops, made a mistake in the first diff that ended up with a duplicate line and a build fail. Attached is the corrected version,

[ Permalink | « Hide ]

Dirty McLean added a comment - 05/Nov/08 10:44 AM - edited

Hopefully fixed in r2325. It would appear that this one case was still indexing by requestID instead of using groupID to comply with the recent changes to GroupManager. I will keep an eye on this issue and close it once it has been confirmed as working.

[ Permalink | « Hide ]

Dirty McLean added a comment - 05/Nov/08 03:12 PM

Ah, yes I see. Hopefully fixed in r2326.

[ Permalink | « Hide ]

Robin Cornelius added a comment - 06/Nov/08 03:11 AM

Tests are looking good

thanks. Results are as expected again.