Issue Details (XML | Word | Printable)

Key: LIBOMV-415
Type: Bug Bug
Status: Resolved Resolved
Resolution: Fixed
Priority: Major Major
Assignee: John Hurliman
Reporter: Teravus
Votes: 0
Watchers: 0
Operations

If you were logged in you would be able to see more operations.
libopenmetaverse

[ PATCH ] - Fails to respect MAX_RESEND_COUNT

Created: 06/Nov/08 03:50 PM   Updated: 10/Nov/08 10:08 AM
Component/s: Networking
Affects Version/s: None
Fix Version/s: 0.6.0

File Attachments: 1. Text File RespectResendCount.patch (2 kB)


Severity: Medium
Environment: All


 Description  « Hide
The resendcount for the packet isn't being updated because it's a value type and never saved back to the dictionary.

The attached patch fixes that issue.

Obviously you can't save to the dictionary while you're enumerating it with foreach, so the packets get added to a list of sequenceIDs to increment and the saved back to the dictionary after the foreach enumeration is done.



 All   Comments   Change History   Subversion Commits   Patches      Sort Order: Ascending order - Click to sort in descending order
John Hurliman added a comment - 10/Nov/08 10:08 AM
Just did a large cleanup of the ack and resend handling code that should address this. Thank you for uncovering this one!