[#LIBOMV-425] small bug when running prebuild under linux

libopenmetaverse

small bug when running prebuild under linux

Created: 16/Nov/08 09:13 AM Updated: 10/Jul/09 12:04 AM

Component/s:

None

Affects Version/s:

0.7.0

Fix Version/s:

0.6.0

File Attachments:

runprebuild-portability.p (0.5 kB)

Environment:	Mono / Linux32
Fixed in Revision:	2412

Description

« Hide

found in revision : 2354

when running runprebuild.sh under linux, i have the following errors :
[: 11: ==: unexpected operator
[: 17: ==: unexpected operator

i purpose to modify the runprebuild.sh script.

FROM :

1. 1. 1. 1. START ###############
        if [ x$1 == xnant ]
        then
        nant -buildfile:OpenMetaverse.build
        exit $?
        fi

if [ x$1 == xprimrender ]
then
nant -buildfile:OpenMetaverse.Rendering.GPL.build
exit $?
fi

1. 1. 1. 1. END ###############
        TO :
        
        START ###############
        case x$1 in
        xnant) nant -buildfile:OpenMetaverse.build;;
        xprimrender) nant -buildfile:OpenMetaverse.Rendering.GPL.build;;
        esac
        
        END ###############

All

Comments

Change History

Subversion Commits

Sort Order:

[ Permalink | « Hide ]

John Hurliman added a comment - 17/Feb/09 11:26 AM

I believe this is fixed. If not, please reopen the issue.

[ Permalink | « Hide ]

Mynonys Mynoduesp added a comment - 05/Jul/09 02:18 PM

I'm still seeing this in trunk@2319

[ Permalink | « Hide ]

Mynonys Mynoduesp added a comment - 05/Jul/09 02:33 PM

commit 62f61edd8827356e5b6d79583808cd1446691704
Author: Subversive Writer <mynonys@gmail.com>
Date: Sun Jul 5 21:29:44 2009 +0100

use "test" rather than [ builtin, for portability

A comment in http://jira.openmetaverse.org/browse/LIBOMV-425 claims that
this issue has been resolved, but as of trunk@2319, I am still seeing
the issue, and don't see anything in the logs indicating it was ever
fixed, so maybe a patch will help things along.

the "test" command is generally considered more portable than the "["
builtin, and it seems that this is justified- when running on my system,
I received the error:
[: 11: x: unexpected operator
[: 17: x: unexpected operator

Some poking around revealed that this was due to the use of "==" for
comparison, while my shell expected "=". The syntax of the "test"
command should be the same everywhere, though

[ Permalink | « Hide ]

Jim Radford added a comment - 05/Jul/09 03:41 PM

re-opening at request of Vincent_ from IRC who attached a patch to be looked into

[ Permalink | « Hide ]

Mynonys Mynoduesp added a comment - 10/Jul/09 12:04 AM

I've learned that my checkout was very very out-of-date (I ran "svn info" on a checkout from last year, then checked it out on another PC- the repository has moved since then!)

This issue was fixed in trunk@2412