Issue Details (XML | Word | Printable)

Key: LIBOMV-429
Type: Bug Bug
Status: Resolved Resolved
Resolution: Fixed
Priority: Minor Minor
Assignee: Latif Khalifa
Reporter: Robin Cornelius
Votes: 0
Watchers: 0
Operations

If you were logged in you would be able to see more operations.
libopenmetaverse

Allow setting appearance to continue even if default textures or some other fail to bake occurs

Created: 13/Dec/08 06:57 AM   Updated: 13/Dec/08 06:04 PM
Component/s: Appearance
Affects Version/s: None
Fix Version/s: 0.6.0

File Attachments: 1. Text File Bail_out_bakes_on_default_textures.patch (2 kB)


Environment: All
Steps to Reproduce: Try to set your appearance with baking if any default linden textures are present


 Description  « Hide
Because the default LL textures are not included with libomv attemping to bake layers with them will fail, but this causes an extra side effect that can be avoided.

Every attempted upload adds to pending uploads, if the bake as failed (due to LL textures or some other reason) UploadBake(Baker bake) will be called with bake.BakedTexture.AssetID==UUID.Zero, this attempts to add a upload with a UUID.Zero to the pending uploads, this of cause will never complete.

UpdateAppearanceFromWearables() which is used in most paths to set what the agent is wearing will block on CachedResponseEvent.WaitOne(); (if baking), this event is only ever set if all pending uploads =0 which cannot occur if the above situation occurs.

Patch attached that does not attempt to add failed bakes, this allows the appearance setting to continue so that any other available bakes and the AgentIsNowWearing() gets called, preventing cloud AV's in many situations.



 All   Comments   Change History   Subversion Commits   Patches      Sort Order: Ascending order - Click to sort in descending order
Latif Khalifa added a comment - 13/Dec/08 06:02 PM
Patch applied, thanks!