Issue Details (XML | Word | Printable)

Key: LIBOMV-459
Type: Bug Bug
Status: Resolved Resolved
Resolution: Fixed
Priority: Minor Minor
Assignee: John Hurliman
Reporter: Peter Tavinor
Votes: 0
Watchers: 0
Operations

If you were logged in you would be able to see more operations.
libopenmetaverse

erron with flags in TextureEntry.cs

Created: 16/Mar/09 10:46 PM   Updated: 17/Mar/09 05:59 PM
Component/s: None
Affects Version/s: None
Fix Version/s: 0.6.0

File Attachments: 1. File OpenMetaverseLib.diff (4 kB)


Environment: All


 Description  « Hide
I have been finding many problems with the openmetaverselib functions that are in the TextureEntry.cs file,
I noticed that when the "bytes" are being read the "material" and "media" fields are being set but the "hasattributes" for them is not
this happens because the material and media fields are "bytes" not "properties" like the "RGBA", "TextureID" etc

I have included a .diff file to fix this problem, but i cannot verify if it will even compile, as i only have Visual studio 2005, and 2008 is required to compile the project

I have checked the changes and am fairly sure it will compile



 All   Comments   Change History   Subversion Commits      Sort Order: Ascending order - Click to sort in descending order
John Hurliman added a comment - 17/Mar/09 05:28 PM
Why did you change the assignment operators for material and media?

This compiles cleanly:

material &= 0xE0;

Your changed version does not (missing a typecast from int to byte):

material = material & 0xE0;


John Hurliman added a comment - 17/Mar/09 05:59 PM
Thank you for the patch, I applied it in r2492 without changing the assignment operators. If this affects the functionality of the patch please reopen this issue.